Skip to content

Update Azure's schema changes during 2025.2.1 upgrade#2965

Merged
viniciusdc merged 4 commits intomainfrom
vini-fix-state-file-schema
Feb 20, 2025
Merged

Update Azure's schema changes during 2025.2.1 upgrade#2965
viniciusdc merged 4 commits intomainfrom
vini-fix-state-file-schema

Conversation

@viniciusdc
Copy link
Copy Markdown
Contributor

@viniciusdc viniciusdc commented Feb 18, 2025 •
edited
Loading

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  • deploy nebari to Azure with 2024.12.1
  • pip install from this branch, and run nebari upgrade

Any other comments?

@viniciusdc
Copy link
Copy Markdown
Contributor Author

viniciusdc commented Feb 18, 2025

I was worried this would affect the main logic of the check_immutable_fields, but I was able to get the error message expected when changing. an immutable field:

ValueError: Attempting to change immutable field "storage.type" ("nfs"->"cephfs") in Nebari config file.  Immutable fields cannot be changed after initial deployment.

@viniciusdc
Copy link
Copy Markdown
Contributor Author

viniciusdc commented Feb 18, 2025

While this addresses the issue, it's not recommended to run refresh as I am doing :

This command is deprecated, because its default behavior is unsafe if you have misconfigured credentials for any of your providers. See below for more information and recommended alternatives.

@viniciusdc viniciusdc changed the title allow state refresh when provider schema changes Update Azure's schema changes during 2025.2.1 upgrade Feb 19, 2025
@viniciusdc
Copy link
Copy Markdown
Contributor Author

viniciusdc commented Feb 19, 2025

Due to the above point, I decided to scrape the idea of using the tofu refresh altogether and instead went with the more straightforward approach of changing the .tfstate file.

@viniciusdc viniciusdc force-pushed the vini-fix-state-file-schema branch from d4955a8 to b704540 Compare February 19, 2025 18:49
@viniciusdc viniciusdc marked this pull request as ready for review February 19, 2025 18:50
@viniciusdc viniciusdc requested a review from a team as a code owner February 19, 2025 18:50
@viniciusdc viniciusdc requested review from dcmcand and marcelovilla and removed request for a team February 19, 2025 18:50
@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label Feb 19, 2025
dcmcand
dcmcand approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dcmcand dcmcand added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels Feb 20, 2025
@viniciusdc viniciusdc merged commit 2bb5669 into main Feb 20, 2025
25 checks passed
@viniciusdc viniciusdc deleted the vini-fix-state-file-schema branch February 20, 2025 15:16
@viniciusdc viniciusdc mentioned this pull request Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcmcand dcmcand dcmcand approved these changes

@marcelovilla marcelovilla Awaiting requested review from marcelovilla marcelovilla is a code owner automatically assigned from nebari-dev/maintenance-team

Assignees

No one assigned

Labels

status: approved 💪🏾 This PR has been reviewed and approved for merge

Projects

🪴 Nebari Project Management
Status: Done 💪🏾

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@viniciusdc @dcmcand